e2e test for memory scaler

[Ritikaa96]

This PR add E2E tests for memory scaler

Checklist

• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• Tests have been added
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable)
• Changelog has been updated and is aligned with our changelog requirements

Fixes #2220

[Ritikaa96]

Hi @tomkerkhove , @JorTurFer
PTAL.

[JorTurFer]

/run-e2e memory.test.ts
Update: You can check the progres here

[JorTurFer]

Hi @Ritikaa96
First, thanks a lot for this ❤️
There are some notation inconsistencies, I have suggested 2 changes but you should review all the places where it happens.

Related with the flow, I'd propose to set less resources to ensure the scaling process (1% instead of 5% for example) and also I'd propose to instead of deleting the first SO and creating another one totally different, patching current SO to update the value. You could achieve it basically creating a variable with the SO template and calling it twice with different parameters to update it.
WDYT?

[zroubalik]

Thanks for this, @JorTurFer have some great comments.

[zroubalik]

/run-e2e memory.test.ts
Update: You can check the progres here

[Ritikaa96]

Hi @Ritikaa96 First, thanks a lot for this heart There are some notation inconsistencies, I have suggested 2 changes but you should review all the places where it happens.

Related with the flow, I'd propose to set less resources to ensure the scaling process (1% instead of 5% for example) and also I'd propose to instead of deleting the first SO and creating another one totally different, patching current SO to update the value. You could achieve it basically creating a variable with the SO template and calling it twice with different parameters to update it. WDYT?

Hi @JorTurFer , Done with the changes, Thanks for the suggestions. PTAL.

[JorTurFer]

LGTM! ❤️
Only 1 small nit about one variable

[Ritikaa96]

Hi @JorTurFer , I apologize for the delay , was stuck because of an emergency. I corrected the variable PTAL.

[JorTurFer]

/run-e2e memory.test.ts
Update: You can check the progres here

[JorTurFer]

LGTM!
Thanks for this, let's wait till e2e passes

[JorTurFer]

Could you update the changelog @Ritikaa96 ?

[Ritikaa96]

Could you update the changelog @Ritikaa96 ?

Sure

[Ritikaa96]

@JorTurFer @zroubalik PTAL