feat: Provide Azure Data Explorer Scaler (#1488) #2627

yardenoff · 2022-02-12T17:41:56Z

Signed-off-by: Yarden Siboni [email protected]

This pull request adds an Azure Data Explorer scaler. This is related to this issue: #1488

Here is the keda-docs PR: kedacore/keda-docs#658

Checklist

Commits are signed with Developer Certificate of Origin (DCO - learn more)
Tests have been added
A PR is opened to update the documentation on (repo) (if applicable)
Changelog has been updated and is aligned with our changelog requirements

Relates to #1488

tomkerkhove · 2022-02-14T06:58:11Z

Thanks a ton, great addition!

tests/scalers/azure-data-explorer.test.ts

pkg/scalers/azure_data_explorer_scaler.go

pkg/scalers/azure/azure_data_explorer.go

pkg/scalers/azure_data_explorer_scaler.go

tests/scalers/azure-data-explorer.test.ts

zroubalik · 2022-02-16T18:18:50Z

/run-e2e azure-data-explorer*
Update: You can check the progres here

yardenoff · 2022-02-16T20:07:33Z

/run-e2e azure-data-explorer* Update: You can check the progres here

Failed with 403 Forbidden status code - Principal 'aadapp=***;***' is not authorized to access database '***'

This az cli command can help with that.

zroubalik · 2022-02-17T12:59:47Z

/run-e2e azure-data-explorer* Update: You can check the progres here

Failed with 403 Forbidden status code - Principal 'aadapp=***;***' is not authorized to access database '***'

This az cli command can help with that.

@tomkerkhove PTAL

yardenoff · 2022-02-25T14:58:47Z

/run-e2e azure-data-explorer* Update: You can check the progres here

Failed with 403 Forbidden status code - Principal 'aadapp=***;***' is not authorized to access database '***'

This az cli command can help with that.

@tomkerkhove PTAL

Any update with the role assignments?

tomkerkhove · 2022-02-28T06:53:22Z

/run-e2e azure-data-explorer*
Update: You can check the progres here

tomkerkhove · 2022-02-28T06:53:35Z

Sorry, I had missed this :/

tomkerkhove · 2022-02-28T07:20:15Z

It failed again but not sure why, or I am looking over it.

yardenoff · 2022-02-28T11:35:24Z

It failed again but not sure why, or I am looking over it.

It failed to create new namespace.
Can you please check that there's no existing ns with the name test-azure-data-explorer-ns?

yardenoff · 2022-02-28T12:01:05Z

It failed again but not sure why, or I am looking over it.

It failed to create new namespace. Can you please check that there's no existing ns with the name test-azure-data-explorer-ns?

@tomkerkhove, I pushed a commit that will create namespace only if it doesn't exist already.
Can you please run the e2e again?

zroubalik · 2022-02-28T12:17:00Z

It failed again but not sure why, or I am looking over it.

It failed to create new namespace. Can you please check that there's no existing ns with the name test-azure-data-explorer-ns?

@tomkerkhove, I pushed a commit that will create namespace only if it doesn't exist already. Can you please run the e2e again?

I think it would be better if it could delete (clean) the namespace if it exists and recreate then.

yardenoff · 2022-02-28T13:52:43Z

It failed again but not sure why, or I am looking over it.

It failed to create new namespace. Can you please check that there's no existing ns with the name test-azure-data-explorer-ns?

@tomkerkhove, I pushed a commit that will create namespace only if it doesn't exist already. Can you please run the e2e again?

I think it would be better if it could delete (clean) the namespace if it exists and recreate then.

done

Edit: I miss understood you. Working on cleaning ns if it exists

tomkerkhove · 2022-02-28T13:58:57Z

It's still creating it if it doesn't exist though - I like Zbynek his suggestion more though.

yardenoff · 2022-02-28T14:15:30Z

This way it will either clean the ns if it exists or create new one if it doesn't. WDYT?

tomkerkhove · 2022-02-28T14:59:20Z

/run-e2e azure-data-explorer*

Update: You can check the progres here

tomkerkhove · 2022-03-11T10:42:37Z

/run-e2e azure-data-explorer*

Update: You can check the progres here

tomkerkhove · 2022-03-11T10:42:55Z

@zroubalik Anything we need as well?

tomkerkhove · 2022-03-11T10:43:07Z

@yasiboni-max Would you mind rebasing main please?

zroubalik

LGTM

Signed-off-by: Yarden Siboni <[email protected]>

CHANGELOG.md

Signed-off-by: Yarden Siboni <[email protected]>

yardenoff · 2022-03-12T21:43:13Z

Not sure why changing one line in CHANGELOG.md caused snyk's security check to fail, and it seems like I don't have enough permissions to see the full report. @tomkerkhove - can you help me with that please?

tomkerkhove

LGTM

tomkerkhove · 2022-03-14T07:24:29Z

Not sure why changing one line in CHANGELOG.md caused snyk's security check to fail, and it seems like I don't have enough permissions to see the full report. @tomkerkhove Tom Kerkhove FTE - can you help me with that please?

It failed to process it, no worries. Thanks for checking (unfortunately we can't make reports public due to Snyk limitation)

Co-authored-by: Yarden Siboni <[email protected]> Signed-off-by: Ram Cohen <[email protected]>

yardenoff requested a review from a team as a code owner February 12, 2022 17:41

yardenoff force-pushed the dev/kusto-scaler branch from 824947b to 098f7ee Compare February 12, 2022 17:45

yardenoff mentioned this pull request Feb 12, 2022

Provide scaler for Azure Data Explorer #1488

Closed

yardenoff force-pushed the dev/kusto-scaler branch 3 times, most recently from c2e32af to 71381f0 Compare February 13, 2022 02:59

zroubalik reviewed Feb 15, 2022

View reviewed changes

zroubalik reviewed Feb 16, 2022

View reviewed changes

tests/scalers/azure-data-explorer.test.ts Outdated Show resolved Hide resolved

tomkerkhove requested a review from zroubalik February 28, 2022 16:29

zroubalik approved these changes Mar 11, 2022

View reviewed changes

yasiboni added 2 commits March 11, 2022 11:43

feat: Provide Azure Data Explorer Scaler (kedacore#1488)

2be9c45

Signed-off-by: Yarden Siboni <[email protected]>

fixed static checks

83e21a1

Signed-off-by: Yarden Siboni <[email protected]>

yasiboni added 5 commits March 11, 2022 11:43

pr comments

51127e0

Signed-off-by: Yarden Siboni <[email protected]>

rename e2e env vars

c3c5cec

Signed-off-by: Yarden Siboni <[email protected]>

Create e2e ns for kusto only if it doesn't exist

6783adb

Signed-off-by: Yarden Siboni <[email protected]>

check if e2e ns exist before creating

8043244

Signed-off-by: Yarden Siboni <[email protected]>

clean ns if e2e ns exist, Otherwise create new ns

431afd7

Signed-off-by: Yarden Siboni <[email protected]>

yardenoff force-pushed the dev/kusto-scaler branch from 0337988 to 431afd7 Compare March 11, 2022 20:09

tomkerkhove reviewed Mar 12, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

yardenoff force-pushed the dev/kusto-scaler branch from 5c6fd7f to 431afd7 Compare March 12, 2022 20:18

align changelog.md with contribution guide instructions

d7f03e5

Signed-off-by: Yarden Siboni <[email protected]>

tomkerkhove approved these changes Mar 14, 2022

View reviewed changes

tomkerkhove merged commit 2f3aaa4 into kedacore:main Mar 14, 2022

RamCohen pushed a commit to RamCohen/keda that referenced this pull request Mar 23, 2022

feat: Provide Azure Data Explorer Scaler (kedacore#1488) (kedacore#2627)

9eb089c

Co-authored-by: Yarden Siboni <[email protected]> Signed-off-by: Ram Cohen <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Provide Azure Data Explorer Scaler (#1488) #2627

feat: Provide Azure Data Explorer Scaler (#1488) #2627

yardenoff commented Feb 12, 2022 •

edited by tomkerkhove

Loading

tomkerkhove commented Feb 14, 2022

zroubalik commented Feb 16, 2022 •

edited by github-actions bot

Loading

yardenoff commented Feb 16, 2022

zroubalik commented Feb 17, 2022

yardenoff commented Feb 25, 2022

tomkerkhove commented Feb 28, 2022 •

edited by github-actions bot

Loading

tomkerkhove commented Feb 28, 2022

tomkerkhove commented Feb 28, 2022

yardenoff commented Feb 28, 2022 •

edited

Loading

yardenoff commented Feb 28, 2022

zroubalik commented Feb 28, 2022

yardenoff commented Feb 28, 2022 •

edited

Loading

tomkerkhove commented Feb 28, 2022

yardenoff commented Feb 28, 2022

tomkerkhove commented Feb 28, 2022 •

edited by github-actions bot

Loading

tomkerkhove commented Mar 11, 2022 •

edited by github-actions bot

Loading

tomkerkhove commented Mar 11, 2022

tomkerkhove commented Mar 11, 2022

zroubalik left a comment

yardenoff commented Mar 12, 2022 •

edited

Loading

tomkerkhove left a comment

tomkerkhove commented Mar 14, 2022

feat: Provide Azure Data Explorer Scaler (#1488) #2627

feat: Provide Azure Data Explorer Scaler (#1488) #2627

Conversation

yardenoff commented Feb 12, 2022 • edited by tomkerkhove Loading

Checklist

tomkerkhove commented Feb 14, 2022

zroubalik commented Feb 16, 2022 • edited by github-actions bot Loading

yardenoff commented Feb 16, 2022

zroubalik commented Feb 17, 2022

yardenoff commented Feb 25, 2022

tomkerkhove commented Feb 28, 2022 • edited by github-actions bot Loading

tomkerkhove commented Feb 28, 2022

tomkerkhove commented Feb 28, 2022

yardenoff commented Feb 28, 2022 • edited Loading

yardenoff commented Feb 28, 2022

zroubalik commented Feb 28, 2022

yardenoff commented Feb 28, 2022 • edited Loading

tomkerkhove commented Feb 28, 2022

yardenoff commented Feb 28, 2022

tomkerkhove commented Feb 28, 2022 • edited by github-actions bot Loading

tomkerkhove commented Mar 11, 2022 • edited by github-actions bot Loading

tomkerkhove commented Mar 11, 2022

tomkerkhove commented Mar 11, 2022

zroubalik left a comment

Choose a reason for hiding this comment

yardenoff commented Mar 12, 2022 • edited Loading

tomkerkhove left a comment

Choose a reason for hiding this comment

tomkerkhove commented Mar 14, 2022

yardenoff commented Feb 12, 2022 •

edited by tomkerkhove

Loading

zroubalik commented Feb 16, 2022 •

edited by github-actions bot

Loading

tomkerkhove commented Feb 28, 2022 •

edited by github-actions bot

Loading

yardenoff commented Feb 28, 2022 •

edited

Loading

yardenoff commented Feb 28, 2022 •

edited

Loading

tomkerkhove commented Feb 28, 2022 •

edited by github-actions bot

Loading

tomkerkhove commented Mar 11, 2022 •

edited by github-actions bot

Loading

yardenoff commented Mar 12, 2022 •

edited

Loading