Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PostgreSQL connectionString generation test #2433

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Add PostgreSQL connectionString generation test #2433

merged 2 commits into from
Jan 4, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Jan 3, 2022 •
edited
Loading

Signed-off-by: jorturfer [email protected]

Add missing test for connectionString generation

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Related #2432

@JorTurFer JorTurFer requested a review from a team as a code owner January 3, 2022 19:42
@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 3, 2022 •
edited by github-actions bot
Loading

/run-e2e postgresql.test*
Update: You can check the progres here

@JorTurFer
Update changelog
e768889 
Signed-off-by: jorturfer <[email protected]>
zroubalik
zroubalik approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik added this to the v2.6.0 milestone Jan 4, 2022
@zroubalik zroubalik merged commit 542c6ce into kedacore:main Jan 4, 2022
@JorTurFer JorTurFer deleted the add_test branch January 4, 2022 08:18
alex60217101990 pushed a commit to dysnix/keda that referenced this pull request Jan 10, 2022
@alex60217101990
Add PostgreSQL connectionString generation test (kedacore#2433)
eb971f8 
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: alex60217101990 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JorTurFer @zroubalik