Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide New Relic scaler #2387

Merged
merged 20 commits into from
Jan 3, 2022
Merged

feat: Provide New Relic scaler #2387

merged 20 commits into from
Jan 3, 2022

Commits on Dec 7, 2021

  1. new-relic scaler 

    Add an option to make empty data returned by query as an error
Make sure test-app has at least 1 pod and keda-test-app is 0 before running tests

Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    dfbaad3 View commit details
    Browse the repository at this point in the history

  2. go.mod/go.sum from main 

    Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    17d9d29 View commit details
    Browse the repository at this point in the history

  3. Fix noDataErr string case 

    add noDataErr to tests
add missinng threshold to tests
add better error description when NerdGraph query fails

Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    d8441e4 View commit details
    Browse the repository at this point in the history

  4. Make metricName optional 

    also fix the test so newrelic is replaced by new-relic to keep consistency on the names

Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    1fd4536 View commit details
    Browse the repository at this point in the history

  5. fix e2e test 

    Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    7c33ba4 View commit details
    Browse the repository at this point in the history

  6. add NewRelic variables to e2e test 

    Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    0a97185 View commit details
    Browse the repository at this point in the history

  7. Added missing NEWRELIC_ACCOUNT_ID to test description on requiered en… 

    …v variables

Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    ea03c28 View commit details
    Browse the repository at this point in the history

  8. add go.mod/go.sum files 

    Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    91ee020 View commit details
    Browse the repository at this point in the history

  9. Update a variable name to make more sense of it use 

    Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    06ee0ea View commit details
    Browse the repository at this point in the history

  10. fix imports 

    Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    6c122b1 View commit details
    Browse the repository at this point in the history

  11. add helm repo update to test 

    Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    a925013 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. another fix to e2e test. 

    Make use of variables for helm package repo instead of hardcoded it (Thanks Jorge!)
Split long lines on the test to make more easy to ready and catch errors

Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    3238c91 View commit details
    Browse the repository at this point in the history

  2. added region as parameter to the e2e test 

    Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    d9470da View commit details
    Browse the repository at this point in the history

  3. update CHANGELOG.md 

    Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    6ed8d22 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Update pkg/scalers/newrelic_scaler.go 

    Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Marcelo Bartsch <[email protected]>
    @zroubalik
    Marcelo Bartsch and zroubalik committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    8aa68e4 View commit details
    Browse the repository at this point in the history

  2. Remove metricName from scaler 

    Rename noDataErr to noDataError

Move 'new-relic' scaler name to a const so don't repeat the string

Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    01ce224 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Merge remote-tracking branch 'origin/main' into new-relic 

    Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    ae1b136 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into new-relic

    Marcelo Bartsch authored Jan 3, 2022
    Configuration menu
    Copy the full SHA
    fb8f0c4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'new-relic' of github.com:marcelobartsch/keda into new-r… 

    …elic

Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    ddc3636 View commit details
    Browse the repository at this point in the history

  4. remove metricName from tests 

    Signed-off-by: Marcelo Bartsch <[email protected]>
    Marcelo Bartsch committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    22519f7 View commit details
    Browse the repository at this point in the history