Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Workload Scaler: ignore terminated pods #2384

Merged

Conversation

solsson
Copy link
Contributor

@solsson solsson commented Dec 5, 2021

The kubernetes-workload scaler is great, but I was surprised to discover that it counts terminated pods. While it's useful to have Shutdown or Completed pods stay around to aid for example troubleshooting I fail to come up with a use case where scaling should count them together with running. This PR excludes the two obvious terminated states from the metric value.

Checklist

@solsson solsson requested a review from a team as a code owner December 5, 2021 07:22
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for your contribution :)

@JorTurFer JorTurFer requested a review from a team December 5, 2021 21:19
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

JorTurFer commented Dec 5, 2021

/run-e2e kubernetes-workload.test*
Update: You can check the progres here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for your contribution ❤️

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @solsson

@zroubalik zroubalik merged commit 4d98f33 into kedacore:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants