improve (azure-pipelines): log url on error

[endersonmenezes]

Signed-off-by: Enderson Menezes [email protected]

Logging URL on Azure Pipelines Scaler Error!

Checklist

• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• Changelog has been updated

---

Hi, I'm new to Go and here at Keda we are running a POC within the company and this little addition helped us to better understand our mistake.

Does this change need to change CHANGELOG? Any other nonsense I've done let me know please!

[JorTurFer]

Thanks a ton for your contribution!
Only small nit

[endersonmenezes]

Thanks a ton for your contribution! Only small nit

I'm going to look for more simple errors like that, and it helps me understand the code better.

Edit: I make error with Signature, i will correct then.

[JorTurFer]

Thanks a ton for your contribution! Only small nit

I'm going to look for more simple errors like that, and it helps me understand the code better.

Edit: I make error with Signature, i will correct then.

You need to amend the wrong commit, adding other one signed it's not enough.
You can see in the docs how to do it:
https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what

[endersonmenezes]

Thanks a ton for your contribution! Only small nit

I'm going to look for more simple errors like that, and it helps me understand the code better.
Edit: I make error with Signature, i will correct then.

You need to amend the wrong commit, adding other one signed it's not enough. You can see in the docs how to do it: https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what

Like that?

[JorTurFer]

Thanks a ton for your contribution! Only small nit

I'm going to look for more simple errors like that, and it helps me understand the code better.
Edit: I make error with Signature, i will correct then.

You need to amend the wrong commit, adding other one signed it's not enough. You can see in the docs how to do it: https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what

Like that?

Yes, exactly like that :)

Thanks a ton!

[JorTurFer]

There is an error yet, could you take a look at it please? 🙏
https://github.com/kedacore/keda/runs/4242581591?check_suite_focus=true
Basically, you should change string(url) to this url on both lines. The casting to string is not necessary because url is already string

[endersonmenezes]

Sorry, i will install pre-commit and take more attention.

[JorTurFer]

Sorry, i will install pre-commit and take more attention.

Don't worry, It happens :)

sorry for this because I didn't see it before:
Error messages in golang shouldn't start with capital letters and that's the error that there is now. :(

Apart from this, personally, I use dev containers in VS Code to avoid installing dependencies in my computer. KEDA supports it and pre-commit is already installed there. I prefer that than installing all dependencies for each project, maybe you'd like it

BTW, thanks for the contribution ❤️

[endersonmenezes]

Sorry, i will install pre-commit and take more attention.

Don't worry, It happens :)

sorry for this because I didn't see it before: Error messages in golang shouldn't start with capital letters and that's the error that there is now. :(

Apart from this, personally, I use dev containers in VS Code to avoid installing dependencies in my computer. KEDA supports it and pre-commit is already installed there. I prefer that than installing all dependencies for each project, maybe you'd like it

BTW, thanks for the contribution heart

i will read this

[JorTurFer]

Thanks ❤️❤️❤️

[tomkerkhove]

Thanks for your contribution, added a question and would you mind updating the changelog please?

[endersonmenezes]

I don't understand why the "CI / Static Checks (pull_request) " failed :(

[JorTurFer]

I don't understand why the "CI / Static Checks (pull_request) " failed :(

I think that it was a random fail :(