WIP - Improve metric name creation to be unique using scaler index #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zroubalik
reviewed
Oct 5, 2021
| for _, metricSpec := range metricSpecs { | ||
| if metricSpec.Resource != nil { | ||
| resourceMetricNames = append(resourceMetricNames, string(metricSpec.Resource.Name)) | ||
| } | ||
|
|
||
| if metricSpec.External != nil { | ||
| // Add the scaler index prefix | ||
| metricSpec.External.Metric.Name = fmt.Sprintf("s%d-%s", scalerIndex, metricSpec.External.Metric.Name) |
There was a problem hiding this comment.
I don't like that we are adding the prefix here, imho scaler.GetMetricSpecForScaling() should return the final metric name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jorturfer [email protected]
This draft shows the approach of using the scaler index as a prefix to ensure all metric names are unique in the ScaledObject. All the metric names will be composed using the pattern
sX-currentMetricNamewherexis the index.I have just tried the changes executing PostgreSQL and MongoDB e2e tests and it works really fine.
I tried to do above the scalers in order to avoid a lot of changes.
@tomkerkhove @zroubalik @ahmelsayed
Could you share your thoughts?
Checklist
Fixes #2123