WIP - Improve metric name creation to be unique #2138
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jorturfer [email protected]
This draft shows the approach that I propose to generate unique metric names in base of the trigger values. All the scalers will contain an option in trigger named
metricName
which supports setting specific metric name instead generate if from hashing result. All the metric names will be composed using the patternscalerType-metricName
I have just tried the change passing mssql e2e tests and it works really fine. Of course, this PR needs a lot of effort yet because all the scalers should be updated, but I'd like to get your opinion about the approach before update all the scalers.
@tomkerkhove @zroubalik
Could you share your thoughts?
Checklist
Updated scalers:
Fixes #2123