Update cron scaler to parse the cron with parser instead of searching for '-' #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ahmelsayed
approved these changes
Aug 18, 2021
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
|
I have just rebased main into this branch to add integrate the changes |
zroubalik
approved these changes
Aug 20, 2021
nilayasiktoprak
pushed a commit
to nilayasiktoprak/keda
that referenced
this pull request
Oct 23, 2021
… for '-' (kedacore#2038) Signed-off-by: jorturfer <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Signed-off-by: nilayasiktoprak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jorturfer [email protected]
This PR changes the method to validate the cron. Now the package parser is used to detect invalid expressions instead a custom method.
Checklist
Fixes #2034