Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation and check in cron scaler for same start and end case #2032

Merged

Conversation

Ritikaa96
Copy link
Contributor

@Ritikaa96 Ritikaa96 commented Aug 12, 2021

Signed-off-by: Ritikaa96 [email protected]

Provide a description of what has been changed
In corn scaler, the target doesn't scale down when the start and end schedule are given the same input.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable) Cron: adding note for improvement keda-docs#515
  • Changelog has been updated

Fixes #2031

@Ritikaa96
Copy link
Contributor Author

@zroubalik @ahmelsayed PTAL

@ahmelsayed
Copy link
Contributor

I'd add a note to the docs here (https://github.com/kedacore/keda-docs/blob/master/content/docs/2.5/scalers/cron.md) about this error case. @tomkerkhove what do you think?

@tomkerkhove
Copy link
Member

Agreed! Let's add it to all versions where CRON is available.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ritikaa96 looking good, could you please add a note to the Changelog (Improvements section) and add note to the docs as @ahmelsayed mentioned. Thanks!

@zroubalik zroubalik added this to the v2.5.0 milestone Aug 18, 2021
@Ritikaa96
Copy link
Contributor Author

@Ritikaa96 looking good, could you please add a note to the Changelog (Improvements section) and add note to the docs as @ahmelsayed mentioned. Thanks!

Sure @zroubalik. Working on it.

Signed-off-by: Ritikaa96 <[email protected]>
@Ritikaa96
Copy link
Contributor Author

@zroubalik @ahmelsayed @tomkerkhove
Added the note in docs with kedacore/keda-docs#515
updated the changelog as well. PTAL

@ahmelsayed ahmelsayed merged commit df89ee2 into kedacore:main Aug 18, 2021
@ahmelsayed
Copy link
Contributor

Thanks @Ritikaa96

nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cron: Target don't scale down if start and end are given same
4 participants