Add Kubernetes Workload scaler #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
Signed-off-by: jorturfer <[email protected]>
JorTurFer
force-pushed
the
workload_autoscaler
branch
from
5d89977
to
e679b92
Compare
Signed-off-by: jorturfer <[email protected]>
zroubalik
reviewed
Aug 5, 2021
Signed-off-by: jorturfer <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]>
JorTurFer
force-pushed
the
workload_autoscaler
branch
from
bf9349a
to
e084cf6
Compare
Signed-off-by: jorturfer <[email protected]>
1 task
Signed-off-by: jorturfer <[email protected]>
zroubalik
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
LGTM, we could potentially add it to 2.4 release, wdyt @tomkerkhove @ahmelsayed ?
|
@JorTurFer the linter is complaining about the empty line, there's probably some char left from the gh suggestion :( |
Signed-off-by: jorturfer <[email protected]>
|
Yes it is. I have just solved it 😁 |
|
That's fine by me @zroubalik but added a remark on the docs PR related to the namespace that we might want to change first if we agree on it. |
Signed-off-by: jorturfer <[email protected]>
ahmelsayed
approved these changes
Aug 5, 2021
|
As we discussed @tomkerkhove @zroubalik, I have just removed the possibility to select the namespace. The search scope is the namespace where the scaledobject is placed |
ahmelsayed
approved these changes
Aug 5, 2021
Signed-off-by: jorturfer <[email protected]>
TsuyoshiUshio
pushed a commit
that referenced
this pull request
Aug 6, 2021
Signed-off-by: jorturfer <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: Tsuyoshi Ushio <[email protected]>
nilayasiktoprak
pushed a commit
to nilayasiktoprak/keda
that referenced
this pull request
Oct 23, 2021
Signed-off-by: jorturfer <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: nilayasiktoprak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new scaler based on the amount of pods which match the selectors (allowing also to specify a specific namespace or all)
With this scaler, you can scale a workload according to another relater workload inside the cluster:
Checklist
Relates to #1735