-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support custom metricName in RabbitMQ scaler #1976
feat: Add support custom metricName in RabbitMQ scaler #1976
Conversation
I need some suggestions on how to fix the tests here: https://github.com/kedacore/keda/blob/main/pkg/scalers/rabbitmq_scaler_test.go#L94-L104. I see that there's no assertion on the generated Should I add a new function and some test data to assert if we are parsing custom |
Yeah, that would be nice! |
@rtnpro would you mind fixing the conflicts, failures and linter problems? Thanks! |
dea79f6
to
2e15f18
Compare
@zroubalik I have updated the test data Let me know what you think about: 2e15f18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, could you please update Changelog and update documentation on kedacore/keda-docs ? Thanks
Fixes kedacore#1975 Signed-off-by: Ratnadeep Debnath <[email protected]>
2e15f18
to
415288d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for the contribution!
@zroubalik I have added the docs fix here: kedacore/keda-docs#499. Thanks for reviewing the PR :) |
Signed-off-by: Ratnadeep Debnath <[email protected]> Signed-off-by: Tsuyoshi Ushio <[email protected]>
Signed-off-by: Ratnadeep Debnath <[email protected]> Signed-off-by: nilayasiktoprak <[email protected]>
This change adds support for parsing custom
metricName
in RabbitMQ scaler, and help to workaround use cases where there's reconcile error for aScaledObject
having duplicate auto generatedmetricName
s, e.g., multiple trigger on the same queue, mode but from different RabbitMQ hosts.Checklist
[ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)Fixes #1975