Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka scaler: batch GetOffset requests #1956

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

lionelvillard
Copy link
Contributor

@lionelvillard lionelvillard commented Jul 13, 2021

Signed-off-by: Lionel Villard [email protected]

Send one request to get all topic offsets instead of one request per partition.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Changelog has been updated

Fixes #

Signed-off-by: Lionel Villard <[email protected]>
Signed-off-by: Lionel Villard <[email protected]>
@lionelvillard
Copy link
Contributor Author

/cc @zroubalik

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik changed the title Batch GetOffset requests Kafka scaler: batch GetOffset requests Jul 13, 2021
@zroubalik
Copy link
Member

Thanks @lionelvillard !

@zroubalik zroubalik merged commit 959c870 into kedacore:main Jul 13, 2021
@zroubalik zroubalik added this to the v2.4.0 milestone Jul 14, 2021
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
Signed-off-by: Lionel Villard <[email protected]>
Signed-off-by: nilayasiktoprak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants