Provide Graphite scaler

[shuoliu1]

Provide a description of what has been changed

Checklist

• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• Tests have been added
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on Provide docs for Graphite scaler keda-docs#425 (if applicable)
• Changelog has been updated

Fixes #1628

[shuoliu1]

@tomkerkhove @ahmelsayed add graphite scaler

[tomkerkhove]

Thanks for the PR! I see you've checked the documentation box but don't see a PR, are you still working on that one?

[shuoliu1]

Thanks for the PR! I see you've checked the documentation box but don't see a PR, are you still working on that one?

I have submitted it, please review

[shuoliu1]

I chose some options wrong, it seems that I can't cancel it

[tomkerkhove]

No problem! Would you mind adding some docs to our doc repo as well please?

[shuoliu1]

No problem! Would you mind adding some docs to our doc repo as well please?

kedacore/keda-docs#425

[zroubalik]

Looking good. Minor comments:

1. Could you please update Changelog? (Unreleased/New section)
2. Could you please implement e2e tests? https://github.com/kedacore/keda/tree/main/tests
3. I am curious about authentication, I see that none is used for this scaler. Do you think that it does make sense to add some option? (not sure what is the common pattern for Graphite)

[zroubalik]

1. Could you please update Changelog? (Unreleased/New section)
2. Could you please implement e2e tests? https://github.com/kedacore/keda/tree/main/tests
3. I am curious about authentication, I see that none is used for this scaler. Do you think that it does make sense to add some option? (not sure what is the common pattern for Graphite)

[shuoliu1]

1. Could you please update Changelog? (Unreleased/New section)
2. Could you please implement e2e tests? https://github.com/kedacore/keda/tree/main/tests
3. I am curious about authentication, I see that none is used for this scaler. Do you think that it does make sense to add some option? (not sure what is the common pattern for Graphite)

1.update Changelog Done
3.basic authentication add Done

[zroubalik]

1. Could you please update Changelog? (Unreleased/New section)
2. Could you please implement e2e tests? https://github.com/kedacore/keda/tree/main/tests
3. I am curious about authentication, I see that none is used for this scaler. Do you think that it does make sense to add some option? (not sure what is the common pattern for Graphite)

1.update Changelog Done
3.basic authentication add Done

Thanks, please open another PR for the documentation of basic authentication parameters. And what about the e2e tests? Do you plan to add them?

[shuoliu1]

1. Could you please update Changelog? (Unreleased/New section)
2. Could you please implement e2e tests? https://github.com/kedacore/keda/tree/main/tests
3. I am curious about authentication, I see that none is used for this scaler. Do you think that it does make sense to add some option? (not sure what is the common pattern for Graphite)

1.update Changelog Done
3.basic authentication add Done

Thanks, please open another PR for the documentation of basic authentication parameters. And what about the e2e tests? Do you plan to add them?
documentation pr kedacore/keda-docs#446
e2e test There's no time for that....

[tomkerkhove]

e2e test There's no time for that....

Unfortunately this is essential before we can merge it so I see a few options:

1. Tests are added to this PR by you and we can merge it
2. You do not have time, but do a reach out to our Slack channel and somebody helps you
3. Close this PR and start as an external scaler first

The reason why it's essential is that we need to guarantee quality but if we don't have the tests then we can't do that. I hope you understand?

[shuoliu1]

The reason why it's essential is that we need to guarantee quality but if we don't have the tests then we can't do that. I hope you understand?

thank you,add tests I will do it at free time

[tomkerkhove]

Thank you!

[tomkerkhove]

Any update on this @shuoliu1 ?

[tomkerkhove]

Just checking in if you'll have time to finish this PR @shuoliu1?

[nmische]

I noticed this scaler is listed in the 2.4 docs, but I don't see evidence of that it is in the 2.4 source. Is this available in 2.4?

[tomkerkhove]

No and I have merged it by accident and forgot to remove it.

kedacore/keda-docs#518

Are you willing to complete this PR?

[nmische]

@tomkerkhove: I am definitely interested in this capability. Let me see if I can find some cycles to dive in over the next week or so.

[tomkerkhove]

Awesome, thank you! Do you want to extend this PR or start fresh? Otherwise I could merge it in a WIP branch on the repo for you.

[nmische]

I will likely extend this PR. Thanks.

[tomkerkhove]

Pushed it to graphite-wip as-is - Thank you @nmische!

[bpinske]

Dang someone beat me to it. I was going to pick this up.

[bpinske]

Just kidding. I did it anyway.

#2092

[tomkerkhove]

Thanks a ton @bpinske!