-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka: provide new option to enable scaling past partition count #1684
Kafka: provide new option to enable scaling past partition count #1684
Conversation
Here an initial proposal. If accepted, I'll add some tests and documentation. |
Would you mind updating the docs please? |
Doc PR: kedacore/keda-docs#407 |
Signed-off-by: Lionel Villard <[email protected]>
d62cc6f
to
5f8ed08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, could you please add a test to check whether the value is parsed correctly?
Isn't this good enough: https://github.com/kedacore/keda/pull/1684/files#diff-74937abdfe4bcd7bfa4682524e865761aa8aa4b824a4fc2f6fe03bdea3a94e14R34 ? |
Would be nice to add entry in here: https://github.com/kedacore/keda/pull/1684/files#diff-74937abdfe4bcd7bfa4682524e865761aa8aa4b824a4fc2f6fe03bdea3a94e14L46 |
Signed-off-by: Lionel Villard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Provide a description of what has been changed
Checklist
Relates to #1683