Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka: provide new option to enable scaling past partition count #1684

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

lionelvillard
Copy link
Contributor

@lionelvillard lionelvillard commented Mar 17, 2021

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Relates to #1683

@lionelvillard
Copy link
Contributor Author

Here an initial proposal. If accepted, I'll add some tests and documentation.

@tomkerkhove
Copy link
Member

Would you mind updating the docs please?

@lionelvillard
Copy link
Contributor Author

Doc PR: kedacore/keda-docs#407

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, could you please add a test to check whether the value is parsed correctly?

@zroubalik zroubalik changed the title provide new option to enable scaling past partition count Kafka: provide new option to enable scaling past partition count Mar 26, 2021
@lionelvillard
Copy link
Contributor Author

Looking good, could you please add a test to check whether the value is parsed correctly?

Isn't this good enough: https://github.com/kedacore/keda/pull/1684/files#diff-74937abdfe4bcd7bfa4682524e865761aa8aa4b824a4fc2f6fe03bdea3a94e14R34 ?

@zroubalik
Copy link
Member

Looking good, could you please add a test to check whether the value is parsed correctly?

Isn't this good enough: https://github.com/kedacore/keda/pull/1684/files#diff-74937abdfe4bcd7bfa4682524e865761aa8aa4b824a4fc2f6fe03bdea3a94e14R34 ?

Would be nice to add entry in here: https://github.com/kedacore/keda/pull/1684/files#diff-74937abdfe4bcd7bfa4682524e865761aa8aa4b824a4fc2f6fe03bdea3a94e14L46
Nothing complex is needed.

Signed-off-by: Lionel Villard <[email protected]>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants