Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak by checking triggers uniqueness properly #1640

Merged
merged 11 commits into from
Mar 1, 2021
Merged

Fix memory leak by checking triggers uniqueness properly #1640

merged 11 commits into from
Mar 1, 2021

Commits on Mar 1, 2021

  1. add metricName to postgres scaler 

    Signed-off-by: ycabrer <[email protected]>
    @ycabrer
    ycabrer committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    c45f41d View commit details
    Browse the repository at this point in the history

  2. fix typo in postgres scaler test 

    Signed-off-by: ycabrer <[email protected]>
    @ycabrer
    ycabrer committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    69c0db3 View commit details
    Browse the repository at this point in the history

  3. close scalers after name check 

    Signed-off-by: ycabrer <[email protected]>
    @ycabrer
    ycabrer committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    f3ac4aa View commit details
    Browse the repository at this point in the history

  4. Update Changelog 

    Signed-off-by: ycabrer <[email protected]>
    @ycabrer
    ycabrer committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    fa243e2 View commit details
    Browse the repository at this point in the history

  5. limit metricName validation to new or changed scaledObjects 

    Signed-off-by: ycabrer <[email protected]>
    @ycabrer
    ycabrer committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    009221d View commit details
    Browse the repository at this point in the history

  6. remove validateMetricNameUniqueness 

    similiar check moved to hpa getScaledObjectMetricSpecs

Signed-off-by: ycabrer <[email protected]>
    @ycabrer
    ycabrer committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    6914f97 View commit details
    Browse the repository at this point in the history

  7. add uniqueness check to getScaledObjectMetricSpecs 

    Signed-off-by: ycabrer <[email protected]>
    @ycabrer
    ycabrer committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    eb315d4 View commit details
    Browse the repository at this point in the history

  8. fix typo 

    Signed-off-by: ycabrer <[email protected]>
    @ycabrer
    ycabrer committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    d2ec27a View commit details
    Browse the repository at this point in the history

  9. remove redundent import 

    Signed-off-by: ycabrer <[email protected]>
    @ycabrer
    ycabrer committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    aac7880 View commit details
    Browse the repository at this point in the history

  10. formatting change 

    Signed-off-by: ycabrer <[email protected]>
    @ycabrer
    ycabrer committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    b819c5e View commit details
    Browse the repository at this point in the history

  11. update changelog 

    Signed-off-by: ycabrer <[email protected]>
    @ycabrer
    ycabrer committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    265b737 View commit details
    Browse the repository at this point in the history