Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenStack Swift scaler e2e tests #1522

Merged

Conversation

pdominguite
Copy link
Contributor

Signed-off-by: Pedro Felipe Dominguite [email protected]

This PR adds end-to-end tests for the OpenStack Swift scaler.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)
  • Changelog has been updated

Relates to #1462.

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, minor nit in Changelog

CHANGELOG.md Outdated Show resolved Hide resolved
tests/.env Outdated Show resolved Hide resolved
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to figure out OpenStack Environment, that can be used to run the test against

@zroubalik zroubalik marked this pull request as draft January 22, 2021 12:11
@zroubalik
Copy link
Member

Marking as draft, until we solve OpenStack Environment

@pdominguite pdominguite force-pushed the add_openstack_swift_scaler_e2e_tests branch 12 times, most recently from dd813ff to 8f5557c Compare February 26, 2021 22:17
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Pedro Felipe Dominguite <[email protected]>

Co-authored-by: Antonio Robson de Paula <[email protected]>

* Add OpenStack helper class

This helper creates an HTTP client using Axios for querying a specific OpenStack project API such as Swift.

Signed-off-by: Pedro Felipe Dominguite <[email protected]>

* Add OpenStack Swift helper class

This helper encapsulates the Swift API operations

Signed-off-by: Pedro Felipe Dominguite <[email protected]>

* Add Axios dependency to package.json

Signed-off-by: Pedro Felipe Dominguite <[email protected]>

* Add environment variables for OpenStack Swift scaler e2e tests

Signed-off-by: Pedro Felipe Dominguite <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Pedro Felipe Dominguite <[email protected]>
Signed-off-by: Pedro Felipe Dominguite <[email protected]>
@pdominguite pdominguite force-pushed the add_openstack_swift_scaler_e2e_tests branch from 8f5557c to 355d329 Compare April 13, 2021 12:13
@zroubalik zroubalik marked this pull request as ready for review April 13, 2021 12:15
@zroubalik zroubalik merged commit d9f8591 into kedacore:main Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants