Fix scaleTarget name reference when resolving pods

[zroubalik]

Signed-off-by: Zbynek Roubalik [email protected]

In #1457 we have overlooked a small problem, Kubernetes Resource was used to reference the name of the target workload. ie. if we were scaling Deployment a string deployments was used to reference the name.

Thus scaling is not working, see the log:

keda-operator-84f7687cfc-qtkch keda-operator 2021-01-06T11:36:51.713Z	INFO	controllers.ScaledObject	Detected resource targeted for scaling	{"ScaledObject.Namespace": "default", "ScaledObject.Name": "hello-scaledobject", "resource": "apps/v1.Deployment", "name": "hello-keda"}
keda-operator-84f7687cfc-qtkch keda-operator 2021-01-06T11:36:51.713Z	INFO	controllers.ScaledObject	Creating a new HPA	{"ScaledObject.Namespace": "default", "ScaledObject.Name": "hello-scaledobject", "HPA.Namespace": "default", "HPA.Name": "keda-hpa-hello-scaledobject"}
keda-operator-84f7687cfc-qtkch keda-operator 2021-01-06T11:36:51.814Z	ERROR	scalehandler	Target deployment doesn't exist	{"resource": "apps/v1, Kind=Deployment", "name": "deployments", "error": "Deployment.apps \"deployments\" not found"}
keda-operator-84f7687cfc-qtkch keda-operator github.com/go-logr/zapr.(*zapLogger).Error
keda-operator-84f7687cfc-qtkch keda-operator 	/go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128
keda-operator-84f7687cfc-qtkch keda-operator github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).getPods
keda-operator-84f7687cfc-qtkch keda-operator 	/workspace/pkg/scaling/scale_handler.go:387
keda-operator-84f7687cfc-qtkch keda-operator github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).GetScalers
keda-operator-84f7687cfc-qtkch keda-operator 	/workspace/pkg/scaling/scale_handler.go:66
keda-operator-84f7687cfc-qtkch keda-operator github.com/kedacore/keda/v2/controllers.(*ScaledObjectReconciler).getScaledObjectMetricSpecs

[zroubalik]

@coderanger FYI

[coderanger]

+1, I completely misread the parsing code. Fixed in #1458 too