Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis cluster scalers #1437

Merged
merged 7 commits into from
Jan 6, 2021
Merged

Redis cluster scalers #1437

merged 7 commits into from
Jan 6, 2021

Conversation

goku321
Copy link
Contributor

@goku321 goku321 commented Dec 20, 2020 •
edited by tomkerkhove
Loading

Add Redis cluster support for Redis list and Redis streams scalers.

Checklist

Relates to #883

@goku321
Copy link
Contributor Author

goku321 commented Dec 20, 2020

Will create the docs PR soon.

@goku321
Fix lint issues
f62b8dd 
Signed-off-by: Deepak <[email protected]>
@goku321
Fix lint issues
c25a5a9 
Signed-off-by: Deepak <[email protected]>
@goku321 goku321 mentioned this pull request Dec 22, 2020
Merged
@goku321
Copy link
Contributor Author

goku321 commented Dec 22, 2020

Docs PR - kedacore/keda-docs#335

@zroubalik
Copy link
Member

Looking good, I am not Redis expert though :)

@mboutet willing to take a look on this?

ahmelsayed
ahmelsayed approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@ahmelsayed ahmelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@tomkerkhove tomkerkhove merged commit d3bacdc into kedacore:main Jan 6, 2021
@goku321 goku321 deleted the redis-cluster-scalers branch January 6, 2021 12:44
ycabrer pushed a commit to ycabrer/keda that referenced this pull request Mar 1, 2021
@goku321 @ycabrer
Redis cluster scalers (kedacore#1437)
be91833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed ahmelsayed approved these changes

Assignees

@zroubalik zroubalik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goku321 @zroubalik @ahmelsayed @tomkerkhove