Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres: optional metricName & mask passwords #1381

Merged
merged 4 commits into from
Dec 1, 2020
Merged

Postgres: optional metricName & mask passwords #1381

merged 4 commits into from
Dec 1, 2020

Conversation

ycabrer
Copy link
Contributor

@ycabrer ycabrer commented Nov 25, 2020 •
edited
Loading

Added metricName as an optional meta field to the Postgres scaler. When not provided one is generated as before but with passwords masked as xxx

Checklist

Issue #1200

@ycabrer ycabrer mentioned this pull request Nov 25, 2020
Merged
@tomkerkhove tomkerkhove changed the title Mask Postgres passwords. Issue #1200 Mask Postgres passwords Nov 26, 2020
zroubalik
zroubalik approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik changed the title Mask Postgres passwords Mask Postgres passwords & optional metricName Nov 26, 2020
@zroubalik zroubalik changed the title Mask Postgres passwords & optional metricName Postgres: optional metricName & mask passwords Nov 26, 2020
@zroubalik
Copy link
Member

Could you please add entry to the Changelog?

@zroubalik zroubalik mentioned this pull request Nov 30, 2020
Merged
4 tasks
@ycabrer
update changelog
6ce3780 
Signed-off-by: ycabrer <[email protected]>
@ycabrer
Copy link
Contributor Author

ycabrer commented Nov 30, 2020

@zroubalik I updated the changelog. Awkward I missed it! Thanks for letting me know.

@ahmelsayed ahmelsayed merged commit 9c86c7c into kedacore:main Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ycabrer @zroubalik @ahmelsayed