[Proposal] Use unique name for metricName for each scaler

[zroubalik]

Currently metric name is hard coded to a specific value (see the example on Kafka scaler), this applies to most of the scalers. Metric name is essential for Metric server and HPA as it is used to distiguish the correct metrics used for scaling.

If we define two or more scalers of the same kind in one ScaledObject, scaling won't be correct as all the scalers will share the same metric name, eg. for Kafka it would be lagThreshold. This could be even problem when using specific combination fo different scalers, as they are using same metric name, eg. Kafka and Stan and probably some others as well.

Using multiple scalers of different kind (or same kind but with different metrics) in one ScaledObject is working: #702

If we want to support multiple scalers, we will need to do modification in every scaler. Each scaler would have to use unique metric name, it's up for discussion what approach would be the best, some of the possibilities are:

• generate unique string
• add unique preffix/suffix to the metric name
• generate unique string/prefix/suffix only if there are mutliple scalers in ScaledObject (to keep the same metric name for the scalers that we have in v1)
• enforce users to set name in trigger metadata in case they will specify more than one scaler in ScaledObject

Use-Case

There could be multiple scalers of the same kind in ScaledObject

Discussion

• Do we want this feature for v2?
• What is the best way to define metric name?

//EDIT added note about Kafka + Stan scalers

[tomkerkhove]

Let's enforce this as of v2.0; think this is a good point of improvement!

add unique preffix/suffix to the metric name

I would go for this as it's consistent across scalers & scenario which we can use in our logging as well

[AmithGanesh]

I think having an optional parameter to provide a unique name . if it's not found then we can generate the unique name based on the parameters for the scalar.

[tomkerkhove]

That's a good suggestion imo!

[zroubalik]

Yeah, but we should bear in mind that the generator must be idempotent, provide the same "unique" value for the same trigger.

[AmithGanesh]

yes. i think we can generate it based on the parameters provided. for example : kafka-scalar-> "kafka-topic-group"

[zroubalik]

@AmithGanesh are you volunteering to implement this? 😄

[AmithGanesh]

yes. i would like to take this up

[zroubalik]

@AmithGanesh what is the status of this please?

[AmithGanesh]

Almost done. will submit a Pull Request by the end of the week.

[zroubalik]

@AmithGanesh that's great! You might want to share your progress on a meeting this Thursday :)

[zroubalik]

@AmithGanesh any update on this?

[AmithGanesh]

opened a PR for this. #866

[zroubalik]

@samuelmacko agreed to finish this

[zroubalik]

Solved in #966