Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate update of KEDA version in the code and yaml files during each release #580

Closed
zroubalik opened this issue Jan 29, 2020 · 6 comments · Fixed by #610
Closed

Automate update of KEDA version in the code and yaml files during each release #580

zroubalik opened this issue Jan 29, 2020 · 6 comments · Fixed by #610
Labels
feature All issues for new features that have been committed to release-management All issues related to how we release

Comments

@zroubalik
Copy link
Member

zroubalik commented Jan 29, 2020

Expected Behavior

We should update a version in https://github.com/kedacore/keda/blob/master/version/version.go during each release. It is set to 1.0.0 currently, which is wrong. This value is printed in logs during the operator startup/run.
Same for the versions in the yaml files under deploy directory

This should be automated

Actual Behavior

Not updated

@zroubalik zroubalik added the bug Something isn't working label Jan 29, 2020
@tomkerkhove
Copy link
Member

That would be a new first step in https://github.com/kedacore/keda/blob/master/RELEASE-PROCESS.MD, is that right?

@tomkerkhove tomkerkhove added the release-management All issues related to how we release label Jan 30, 2020
@zroubalik
Copy link
Member Author

Yes, but I'd like to see it automated. I am not that much familiar with GitHub workflows, so not sure if that's possible. But it is a matter of very simple bash script and regex.

@zroubalik
Copy link
Member Author

@ahmelsayed might know it better

@zroubalik zroubalik changed the title Update a version in version/version.go during each release Automate update of KEDA version in the code and yaml files during each release Feb 4, 2020
@zroubalik zroubalik added feature All issues for new features that have been committed to and removed bug Something isn't working labels Feb 4, 2020
@Cottonglow
Copy link
Contributor

The Makefile in #596 will replace the version in version.go but the PR also introduces more files that need to be substituted.

The deploy yaml files will include a version label which currently would need to be updated manually before each release.

I have found a few ways of getting this to potentially work - although unsure whether they are too hacky:

  1. Run a script to sed the version before creating a release
  2. Update the Makefile to sed the yaml files and output the new files into a build/deploy folder

The 2nd one would mean people need to go into the build/deploy directory to get the new scripts instead of the deploy directory currently.
Unless we have a template/deploy folder with the yaml files, copy those files to the deploy folder (to prevent updating files in 2 places) and do the variable substitution with sed.

@zroubalik
Copy link
Member Author

@Cottonglow I think that a new target, like make release or make prepare-release or something like that would be great.

It would change the versions in version.go and yaml files (both the app.kubernetes.io/version: and image reference). So then it could be the first step in the release process.

@Cottonglow
Copy link
Contributor

I've created the above PR which contains a new target release. I gave it a dry run on my side and it seems to work. Would be happy for someone else to test it as well just in case.

SpiritZhou pushed a commit to SpiritZhou/keda that referenced this issue Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature All issues for new features that have been committed to release-management All issues related to how we release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants