Fix e2e test in non-opentelemetry case #5578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @SpiritZhou |
Signed-off-by: Joel Smith <[email protected]>
|
/run-e2e internal |
|
@zroubalik Thanks for taking a look |
zroubalik
approved these changes
Mar 8, 2024
SpiritZhou
pushed a commit
to SpiritZhou/keda
that referenced
this pull request
Mar 15, 2024
Signed-off-by: Joel Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If running e2e tests without
ENABLE_OPENTELEMETRY=true, the tests fail during teardown when it tries to remove opentelemetry-related test items. This PR skips the removal when the setup was skipped.Checklist
Relates to #5375, #5436