Skip to content

Commit

Permalink
e2e: Don't try to remove opentelemetry if not installed
Browse files Browse the repository at this point in the history
Signed-off-by: Joel Smith <[email protected]>
  • Loading branch information
joelsmith committed Mar 7, 2024
1 parent 610f812 commit 73d355a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ New deprecation(s):
### Other

- **General**: Improve readability of utility function getParameterFromConfigV2 ([#5037](https://github.com/kedacore/keda/issues/5037))
- **General**: Introduce ENABLE_OPENTELEMETRY in deploying/testing process ([#5375](https://github.com/kedacore/keda/issues/5375))
- **General**: Introduce ENABLE_OPENTELEMETRY in deploying/testing process ([#5375](https://github.com/kedacore/keda/issues/5375), [#5578](https://github.com/kedacore/keda/issues/5578))
- **General**: Migrate away from unmaintained golang/mock and use uber/gomock ([#5440](https://github.com/kedacore/keda/issues/5440))
- **General**: Minor refactor to reduce copy/paste code in ScaledObject webhook ([#5397](https://github.com/kedacore/keda/issues/5397))

Expand Down
4 changes: 4 additions & 0 deletions tests/utils/cleanup_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ func TestRemoveGcpIdentityComponents(t *testing.T) {
}

func TestRemoveOpentelemetryComponents(t *testing.T) {
if EnableOpentelemetry == "" || EnableOpentelemetry == StringFalse {
t.Skip("skipping uninstall of opentelemetry")
}

_, err := ExecuteCommand(fmt.Sprintf("helm uninstall opentelemetry-collector --namespace %s", OpentelemetryNamespace))
require.NoErrorf(t, err, "cannot uninstall opentelemetry-collector - %s", err)
DeleteNamespace(t, OpentelemetryNamespace)
Expand Down

0 comments on commit 73d355a

Please sign in to comment.