Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostreSQL scaler #546

Closed
dimberman opened this issue Jan 16, 2020 · 5 comments
Closed

PostreSQL scaler #546

dimberman opened this issue Jan 16, 2020 · 5 comments
Assignees
Labels
docs:pending All issues where docs are pending addition/update feature All issues for new features that have been committed to scaler scaler-postgresql

Comments

@dimberman
Copy link
Contributor

A clear and concise description of what scaler you'd like to use and how you'd want to use it:

  • Scaler Source:

Scaler source would be a postGRES database

  • How do you want to scale:

When the user creates the scaledObject, they would fill in a "query" parameter that accepts a string. If the string returns an integer, KEDA will autoscale to this integer. If it returns anything else, KEDA will report an error.

  • Authentication:

Users will be able to place a postGRES password into a kubernetes secret for connecting to the database.

@dimberman dimberman changed the title PostGRES sca PostGRES scaler Jan 16, 2020
@dimberman dimberman changed the title PostGRES scaler PostreSQL scaler Jan 16, 2020
@tomkerkhove tomkerkhove added docs:pending All issues where docs are pending addition/update feature All issues for new features that have been committed to and removed needs-discussion labels Jan 17, 2020
@tomkerkhove
Copy link
Member

Thanks @dimberman!

In terms of authentication, it would be good if it supports trigger authentication so that folks who want to can use env vars as well (although they shouldn't but sometimes have to) so that it aligns with other scalers. But I presume that was your plan?

@dimberman
Copy link
Contributor Author

Hi @tomkerkhove,

So for the airflow use-case, we would have a unique postgres per-deployment that KEDA would be speaking to, though I can see situations where multiple deployments would want to speak to a single central PG instance.

If I follow the example of the redis_scaler, would that be sufficient?

@tomkerkhove
Copy link
Member

Code via #553

Would you be up for documenting the new scaler in https://github.com/kedacore/keda-docs as well please?

So for the airflow use-case, we would have a unique postgres per-deployment that KEDA would be speaking to, though I can see situations where multiple deployments would want to speak to a single central PG instance.

If I follow the example of the redis_scaler, would that be sufficient?

A bit late to reply but yes that should help you

@dimberman
Copy link
Contributor Author

@tomkerkhove on it!

@tomkerkhove
Copy link
Member

Docs are done, thanks!

preflightsiren pushed a commit to preflightsiren/keda that referenced this issue Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs:pending All issues where docs are pending addition/update feature All issues for new features that have been committed to scaler scaler-postgresql
Projects
None yet
Development

No branches or pull requests

2 participants