Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returns unmatched error when updating hpa object failed #2719

Closed
Shitaibin opened this issue Mar 7, 2022 · 0 comments · Fixed by #2677
Closed

Returns unmatched error when updating hpa object failed #2719

Shitaibin opened this issue Mar 7, 2022 · 0 comments · Fixed by #2677
Labels
bug Something isn't working

Comments

@Shitaibin
Copy link
Contributor

Report

In updateHPAIfNeeded, it should return error of update hpa object not newHPAForScaledObject, if updating failed.

Expected Behavior

returns error of updating instead of newHPAForScaledObject

Actual Behavior

returns the error of newHPAForScaledObject

Steps to Reproduce the Problem

  1. deploy a scale object
  2. changing the hpa configureations of the scale object
  3. occasionally, mismatched errors are logged

Logs from KEDA operator

example

KEDA Version

2.6.1

Kubernetes Version

1.23

Platform

Any

Scaler Details

No response

Anything else?

No response
@Shitaibin Shitaibin added the bug Something isn't working label Mar 7, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Mar 7, 2022
Shitaibin added a commit to Shitaibin/keda that referenced this issue Mar 7, 2022
@Shitaibin
Fix returns unmatched error when updating hpa object failed (kedacore…
57fabef 
…#2719)

Signed-off-by: shitaibin <[email protected]>
@zroubalik zroubalik moved this from Proposed to In Review in Roadmap - KEDA Core Mar 7, 2022
@zroubalik zroubalik mentioned this issue Mar 7, 2022
Merged
5 tasks
@JorTurFer JorTurFer moved this from In Review to In Progress in Roadmap - KEDA Core Mar 7, 2022
@JorTurFer JorTurFer moved this from In Progress to In Review in Roadmap - KEDA Core Mar 7, 2022
Shitaibin added a commit to Shitaibin/keda that referenced this issue Mar 16, 2022
@Shitaibin
Fix returns unmatched error when updating hpa object failed (kedacore…
1c826dc 
…#2719)

Signed-off-by: shitaibin <[email protected]>
Shitaibin added a commit to Shitaibin/keda that referenced this issue Mar 16, 2022
@Shitaibin
Fix returns unmatched error when updating hpa object failed (kedacore…
dba5bff 
…#2719)

Signed-off-by: shitaibin <[email protected]>
Repository owner moved this from In Review to Ready To Ship in Roadmap - KEDA Core Mar 17, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix returns unmatched error when updating hpa object failed Shitaibin/keda
1 participant
@Shitaibin