Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution url in the pr-e2e triggering comment and fix problem related with not starting with #2306

Merged
merged 4 commits into from
Nov 23, 2021

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Nov 20, 2021

Using the on-demand e2e test feature, we discovered that getting the execution url is useful to check what happened in case of failure. This PR modifies the workflow in order to update the trigger comment with a link to the execution.

EDIT: I converted it to draw again because I'd like to solve the problem with the replies also in this PR

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Fixes #2224 (reply in thread)

@JorTurFer JorTurFer changed the title Add execution url in the pr-e2e trigger comment Add execution url in the pr-e2e triggering comment Nov 20, 2021
Signed-off-by: jorturfer <[email protected]>
@JorTurFer JorTurFer changed the title Add execution url in the pr-e2e triggering comment WIP - Add execution url in the pr-e2e triggering comment Nov 22, 2021
@JorTurFer JorTurFer marked this pull request as draft November 22, 2021 10:13
@JorTurFer
Copy link
Member Author

There is an opened issue in the action repository about it : Prefix_only doesn't work Prefix_only doesn't work
I will try to figure out a solution for this

@JorTurFer JorTurFer changed the title WIP - Add execution url in the pr-e2e triggering comment Add execution url in the pr-e2e triggering comment and fix problem related with not starting with Nov 22, 2021
Signed-off-by: Jorge Turrado <[email protected]>
@JorTurFer JorTurFer marked this pull request as ready for review November 22, 2021 11:15
@JorTurFer
Copy link
Member Author

JorTurFer commented Nov 22, 2021

There is an opened issue in the action repository about it : Prefix_only doesn't work Prefix_only doesn't work I will try to figure out a solution for this

I have solved this problem checking directly the comment body from the context (github.event.comment.body) using built-in functions

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zroubalik zroubalik merged commit e748176 into kedacore:main Nov 23, 2021
@JorTurFer JorTurFer deleted the execution_url branch November 23, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants