Skip to content

Commit

Permalink
Add execution url in the pr-e2e triggering comment and fix problem re…
Browse files Browse the repository at this point in the history
…lated with not starting with (#2306)

Signed-off-by: Jorge Turrado <[email protected]>
  • Loading branch information
Jorge Turrado Ferrero authored Nov 23, 2021
1 parent cf1b365 commit e748176
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 18 deletions.
28 changes: 10 additions & 18 deletions .github/workflows/pr-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,33 +7,17 @@ jobs:
runs-on: ubuntu-latest
name: Comment evaluate
outputs:
run-e2e: ${{ steps.check-comment.outputs.triggered == 'true' && steps.check-permission.outputs.has-permission }}
run-e2e: ${{ startsWith(github.event.comment.body,'/run-e2e') && steps.check-permission.outputs.has-permission }}
steps:
- uses: khan/pull-request-comment-trigger@master
id: check-comment
with:
trigger: '/run-e2e'
prefix_only: true
env:
GITHUB_TOKEN: '${{ secrets.GITHUB_TOKEN }}'

- name: Check user permission
if: steps.check-comment.outputs.triggered == 'true'
if: startsWith(github.event.comment.body,'/run-e2e')
id: check-permission
uses: scherermichael-oss/action-has-permission@master
with:
required-permission: write
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: React to comment with rocket
uses: dkershner6/reaction-action@v1
if: steps.check-comment.outputs.triggered == 'true' && steps.check-permission.outputs.has-permission
with:
token: ${{ secrets.GITHUB_TOKEN }}
commentId: ${{ github.event.comment.id }}
reaction: "rocket"

run-test:
needs: check
runs-on: ubuntu-latest
Expand All @@ -44,6 +28,14 @@ jobs:
steps:
- uses: actions/checkout@v2

- name: Update comment with the execution url
uses: peter-evans/create-or-update-comment@v1
with:
comment-id: ${{ github.event.comment.id }}
body: |
**Update:** You can check the progres [here](https://github.com/${{github.repository}}/actions/runs/${{github.run_id}})
reactions: rocket

- name: Checkout Pull Request
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
- Add Makefile mockgen targets ([#2090](https://github.com/kedacore/keda/issues/2090)|[#2184](https://github.com/kedacore/keda/pull/2184))
- Drop support to `ValueMetricType` using cpu_memory_scaler ([#2218](https://github.com/kedacore/keda/issues/2218))
- Add github action to run e2e command "on-demand" ([#2241](https://github.com/kedacore/keda/issues/2241))
- Add execution url in the pr-e2e triggering comment and fix problem related with not starting with ([#2306](https://github.com/kedacore/keda/issues/2306))

## v2.4.0

Expand Down

0 comments on commit e748176

Please sign in to comment.