Can the docker image name be changed from keda-metrics-adapter to keda-metrics-apiserver?

[ckuduvalli]

A clear and concise description of what you want to happen.

Currently we are using the name keda-metrics-apiserver for POD_NAME, SERVICE_NAME and so on. Only the docker image is called keda-metrics-adapter. Can we please change the docker image name also to keda-metrics-apiserver when v2 is released?

@zroubalik @tomkerkhove
Kindly suggest

[tomkerkhove]

I'll leave this up to @zroubalik but for me this sounds ok.

[zroubalik]

Sounds good to me. @ckuduvalli are you willing to contribute this?

[ckuduvalli]

yes i will change it and send a pr

[tomkerkhove]

Awesome, thanks! Would you mind updating our Helm charts as well?

[ckuduvalli]

@tomkerkhove @zroubalik
For this change, I am not sure what to add and where to add documentation in keda-docs. Also, not sure about tests and changelog. Kindly help.

@tomkerkhove
could you please let me know how to update helm charts for this change?

[zroubalik]

Reopening for helm charts

[zroubalik]

@ckuduvalli tests are not needed imho, and for changelog. I'll include this note to my already opened PR for changelog:#1086

[ckuduvalli]

Thank you @zroubalik

[ckuduvalli]

@zroubalik @tomkerkhove
Have made the helm charts change
kedacore/charts#66

[tomkerkhove]

Should we add this to https://github.com/kedacore/keda-docs/blob/master/content/docs/2.0/migration.md @zroubalik ?

[zroubalik]

@tomkerkhove IMHO it is not needed, it is covered in Changelog and this change is not something that is directly affecting users.

[flyingfang]

Hey, there is a bug in the pr...The image key "metricsAdapter" in values.yaml has not been changed.

[tomkerkhove]

This you mean? https://github.com/kedacore/charts/pull/66/files#diff-c7bc2dee6b0e6a8755bd9c0383b7a103R7

[flyingfang]

This you mean? https://github.com/kedacore/charts/pull/66/files#diff-c7bc2dee6b0e6a8755bd9c0383b7a103R7

should be "metricsApiServer: docker.io/kedacore/keda-metrics-apiserver:1.5.0"

[tomkerkhove]

Woops, thanks for letting us know! Fixing it now.