close scalers after name check

Signed-off-by: ycabrer <[email protected]>
kedacore · Mar 1, 2021 · f3ac4aa · f3ac4aa
1 parent 69c0db3
commit f3ac4aa
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/controllers/scaledobject_controller.go b/controllers/scaledobject_controller.go
@@ -201,6 +201,7 @@ func (r *ScaledObjectReconciler) reconcileScaledObject(logger logr.Logger, scale
 		return "ScaledObject doesn't have correct scaleTargetRef specification", err
 	}
 
+	// Check for any duplicate names in scaledObject
 	err = r.validateMetricNameUniqueness(logger, scaledObject)
 	if err != nil {
 		return "Error checking metric name uniqueness", err
@@ -260,6 +261,8 @@ func (r *ScaledObjectReconciler) validateMetricNameUniqueness(logger logr.Logger
 
 	observedMetricNames := make(map[string]struct{})
 	for _, scaler := range scalers {
+		defer scaler.Close()
+
 		for _, metric := range scaler.GetMetricSpecForScaling() {
 			// Only validate external metricNames
 			if metric.External == nil {