Skip to content

Commit

Permalink
fix(github-runner-scaler) Add support for key authentication against …
Browse files Browse the repository at this point in the history
…GHES (#5384)

Signed-off-by: Adam Netočný <[email protected]>
  • Loading branch information
Eddman authored Jan 16, 2024
1 parent 56385f1 commit 8f3e0d6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ Here is an overview of all new **experimental** features:
- **Azure Pipelines**: No more HTTP 400 errors produced by poolName with spaces ([#5107](https://github.com/kedacore/keda/issues/5107))
- **GCP pubsub scaler**: Added `project_id` to filter for metrics queries ([#5256](https://github.com/kedacore/keda/issues/5256))
- **GCP pubsub scaler**: Missing use of default value of `value` added ([#5093](https://github.com/kedacore/keda/issues/5093))
- **Github Runner Scaler**: github-runner-scaler is unable to work with custom API endpoint ([#5387](https://github.com/kedacore/keda/issues/5387))
- **NATS JetSteam Scaler**: Raise an error if leader not found ([#5358](https://github.com/kedacore/keda/pull/5358))
- **Pulsar scaler**: Fix panic when auth is not used ([#5271](https://github.com/kedacore/keda/issues/5271))
- **ScaledJobs**: Copy ScaledJob annotations to child Jobs ([#4594](https://github.com/kedacore/keda/issues/4594))
Expand Down
1 change: 1 addition & 0 deletions pkg/scalers/github_runner_scaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ func NewGitHubRunnerScaler(config *scalersconfig.ScalerConfig) (Scaler, error) {
if err != nil {
return nil, fmt.Errorf("error creating GitHub App client: %w, \n appID: %d, instID: %d", err, meta.applicationID, meta.installationID)
}
hc.BaseURL = meta.githubAPIURL
httpClient = &http.Client{Transport: hc}
}

Expand Down

0 comments on commit 8f3e0d6

Please sign in to comment.