Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the support for different metric types #657

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

amirschw
Copy link
Contributor

@amirschw amirschw commented Feb 11, 2022

Related PR in the keda repo: kedacore/keda#2309.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Signed-off-by: amirschw [email protected]

Relates to kedacore/keda#2030

@netlify
Copy link

netlify bot commented Feb 11, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit a71fc7c
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/62437b28348c8e0008e32cc4
😎 Deploy Preview https://deploy-preview-657--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a few notes

content/docs/2.7/concepts/scaling-deployments.md Outdated Show resolved Hide resolved
Copy link
Contributor

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a small suggestion, but I don't think that's strictly necessary for this PR to be merged.

content/docs/2.7/concepts/scaling-deployments.md Outdated Show resolved Hide resolved
content/docs/2.7/concepts/scaling-deployments.md Outdated Show resolved Hide resolved
content/docs/2.7/concepts/scaling-deployments.md Outdated Show resolved Hide resolved
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the example

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits :)

@amirschw FYI

content/docs/2.7/scalers/cpu.md Show resolved Hide resolved
content/docs/2.7/concepts/scaling-deployments.md Outdated Show resolved Hide resolved
@zroubalik zroubalik merged commit 862f1f6 into kedacore:main Mar 30, 2022
@amirschw amirschw deleted the metric-type branch March 30, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants