Add Cassandra Scaler doc #452
Conversation
Signed-off-by: nilayasiktoprak <[email protected]>
nilayasiktoprak
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
| authenticationRef: | ||
| name: keda-trigger-auth-cassandra-secret |
There was a problem hiding this comment.
This can be left out here
| authenticationRef: | |
| name: keda-trigger-auth-cassandra-secret |
| - `username` - The username credential for connecting to the Cassandra instance. | ||
| - `clusterIPAddress` - The IP address or the host name of the Cassandra instance, with port number (optional). | ||
| - `consistency` - Configuration for a session or per individual read or write operation. | ||
| - `protoVersion` - CQL Binary Protocol. |
There was a problem hiding this comment.
How about using protocolVersion?
| - `protoVersion` - CQL Binary Protocol. | |
| - `protocolVersion` - CQL Binary Protocol. |
|
|
||
| - `username` - The username credential for connecting to the Cassandra instance. | ||
| - `clusterIPAddress` - The IP address or the host name of the Cassandra instance, with port number (optional). | ||
| - `consistency` - Configuration for a session or per individual read or write operation. |
There was a problem hiding this comment.
Maybe leave this out since we don't do writes?
| - `consistency` - Configuration for a session or per individual read or write operation. | |
| - `consistency` - Configuration for a session or per individual read operation. |
| **Parameter list:** | ||
|
|
||
| - `username` - The username credential for connecting to the Cassandra instance. | ||
| - `clusterIPAddress` - The IP address or the host name of the Cassandra instance, with port number (optional). |
There was a problem hiding this comment.
@zroubalik We had a scaler where we support full name and name + port separately, do you recall where we changed this? We might want to align here.
There was a problem hiding this comment.
I believe that it might be MSSQL scaler since the port is indicated as optional in the doc here: https://github.com/kedacore/keda-docs/blob/master/content/docs/2.3/scalers/mssql.md
So you mean that we should also support port as optional, right?
There was a problem hiding this comment.
I believe that it might be MSSQL scaler since the port is indicated as optional in the doc here: https://github.com/kedacore/keda-docs/blob/master/content/docs/2.3/scalers/mssql.md
So you mean that we should also supportportas optional, right?
Is this right? @tomkerkhove
There was a problem hiding this comment.
I'd love to align this indeed, what do you think @zroubalik ?
There was a problem hiding this comment.
Yeah, I'd prefer to have the ability to specify the port in an optional field.
Signed-off-by: nilayasiktoprak <[email protected]>
Signed-off-by: nilayasiktoprak [email protected]
This PR adds documentation for Cassandra Scaler.
Relates to kedacore/keda#1841
Checklist