Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: support username and password auth for etcd #1488

Merged
merged 1 commit into from
Oct 21, 2024
Merged

docs: support username and password auth for etcd #1488

merged 1 commit into from
Oct 21, 2024

Conversation

dovics
Copy link
Contributor

@dovics dovics commented Oct 20, 2024

Add Support for Username and Password Authentication for etcd

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates: kedacore/keda#6199

@dovics dovics requested a review from a team as a code owner October 20, 2024 15:13
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Oct 20, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 9b167b0
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/67151e01452f860008ce521c
😎 Deploy Preview https://deploy-preview-1488--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

wozniakjan
wozniakjan approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan wozniakjan merged commit ddccbf7 into kedacore:main Oct 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dovics @wozniakjan