Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initialDelayCooldownPeriod parameter to KEDA ScaledObject Doc #1337

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

RonaldFletcher
Copy link
Contributor

@RonaldFletcher RonaldFletcher commented Mar 18, 2024

This commit introduces the parameter for KEDA's ScaledObject resource. This parameter sets a delay before the activates after the initial creation of the ScaledObject. By default, this delay is 0 seconds. If configured, e.g., to 120 seconds, the cooldown period only begins after the ScaledObject has been active for the specified duration. This feature allows for more controlled scaling behavior during the initial deployment phase.

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#5008
Relates to kedacore/keda#5478

@RonaldFletcher RonaldFletcher requested a review from a team as a code owner March 18, 2024 01:58
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit d52f1e4
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66173d56d82e240008d3a54d
😎 Deploy Preview https://deploy-preview-1337--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RonaldFletcher RonaldFletcher changed the title Added parameter to KEDA ScaledObject Doc Added initialDelayCooldownPeriod parameter to KEDA ScaledObject Doc Mar 18, 2024
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 😄

Could you undo unrelated changes? 🙏 (spaces, new lines, etc)

content/docs/2.14/concepts/scaling-deployments.md Outdated Show resolved Hide resolved
This commit introduces the initialDelayCooldownPeriod parameter for KEDA's ScaledObject resource. This parameter sets a delay before the cooldownPeriod activates after the initial creation of the ScaledObject. By default, this delay is 0 seconds. If configured, e.g., to 120 seconds, the cooldown period only begins after the ScaledObject has been active for the specified duration. This feature allows for more controlled scaling behavior during the initial deployment phase.

Signed-off-by: wangxingrui <[email protected]>
@RonaldFletcher
Copy link
Contributor Author

Looking good! 😄

Could you undo unrelated changes? 🙏 (spaces, new lines, etc)

i have already done @JorTurFer

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just please rename to initialCooldownPeriod

@RonaldFletcher
Copy link
Contributor Author

@zroubalik done

@zroubalik zroubalik merged commit 09f2857 into kedacore:main Apr 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants