Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs for support aws secretmanager authentication #1289

Merged
merged 9 commits into from
Jan 12, 2024
Merged

add docs for support aws secretmanager authentication #1289

merged 9 commits into from
Jan 12, 2024

Conversation

geoffrey1330
Copy link
Contributor

@geoffrey1330 geoffrey1330 commented Jan 11, 2024 •
edited
Loading

Signed-off-by: geoffrey1330 [email protected]

Added docs for support aws secretmanager authentication

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@geoffrey1330 geoffrey1330 requested a review from a team as a code owner January 11, 2024 18:51
@netlify Netlify
Copy link

netlify bot commented Jan 11, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit b88383d
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65a14b232ecaef0008d99c74
😎 Deploy Preview https://deploy-preview-1289--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@geoffrey1330
Copy link
Contributor Author

Hi @JorTurFer Here is the docs.

@zroubalik zroubalik mentioned this pull request Jan 12, 2024
Merged
7 tasks
@geoffrey1330
Copy link
Contributor Author

@JorTurFer I've resolved all suggested changes.
cc @zroubalik

@zroubalik zroubalik merged commit 7579e54 into kedacore:main Jan 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geoffrey1330 @zroubalik @JorTurFer