-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support profiling for keda components #1250
Conversation
Signed-off-by: yuval weber <[email protected]>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: yuval weber <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: yuval weber <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: yuval weber <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: yuval weber <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: yuval weber <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: yuval weber <[email protected]>
Signed-off-by: yuval weber <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]> Signed-off-by: yuval weber <[email protected]>
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! But this page is automatically updated and you need to create a new file under https://github.com/kedacore/keda-docs/tree/main/content/troubleshooting
You can see in the preview why: https://deploy-preview-1250--keda.netlify.app/docs/2.13/troubleshooting/ |
Hey @tomkerkhove not sure I understand. |
@tomkerkhove actually I think that we should change this approach and have a specific content for each version. For example the stuff added in this PR is only valid on versions 2.13+ and also in the current apporach we can't get links to the specific topics in the guide. |
I think we should fix how the troubleshooting widgets are added to be per version, but do think they should all be in separate files as we have it today |
Out of curiosity, why? The rest of the website is done this way :) I don't mind whether the items are in the same file or not, I just want to have it versioned and be able to give a link to specific problem. To not be completely off topic, @yuvalweber could you please put your stuff the old way, as @tomkerkhove suggested and we will tackle the refactoring in a separate task. Thanks a lot! |
Signed-off-by: yuval weber <[email protected]>
Added it in different section like you asked @zroubalik. |
Hey @tomkerkhove it won't let me merge because of your change request which I address to |
Provide a description of what has been changed
Checklist
Fixes kedacore/keda#4789