Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support profiling for keda components #1250

Merged
merged 10 commits into from
Oct 31, 2023
Merged

Conversation

yuvalweber
Copy link
Contributor

@yuvalweber yuvalweber commented Oct 17, 2023

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#4789

@yuvalweber yuvalweber requested a review from a team as a code owner October 17, 2023 14:03
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit ed28616
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65315839549ef700081cdbf2
😎 Deploy Preview https://deploy-preview-1250--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

content/docs/2.13/troubleshooting.md Outdated Show resolved Hide resolved
content/docs/2.13/troubleshooting.md Outdated Show resolved Hide resolved
content/docs/2.13/troubleshooting.md Outdated Show resolved Hide resolved
content/docs/2.13/troubleshooting.md Outdated Show resolved Hide resolved
content/docs/2.13/troubleshooting.md Outdated Show resolved Hide resolved
content/docs/2.13/troubleshooting.md Outdated Show resolved Hide resolved
content/docs/2.13/troubleshooting.md Outdated Show resolved Hide resolved
yuvalweber and others added 7 commits October 18, 2023 14:29
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: yuval weber <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: yuval weber <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: yuval weber <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: yuval weber <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: yuval weber <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: yuval weber <[email protected]>
Signed-off-by: yuval weber <[email protected]>
content/docs/2.13/troubleshooting.md Outdated Show resolved Hide resolved
Co-authored-by: Zbynek Roubalik <[email protected]>
Signed-off-by: yuval weber <[email protected]>
@yuvalweber
Copy link
Contributor Author

Done 👍

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! But this page is automatically updated and you need to create a new file under https://github.com/kedacore/keda-docs/tree/main/content/troubleshooting

@tomkerkhove
Copy link
Member

You can see in the preview why: https://deploy-preview-1250--keda.netlify.app/docs/2.13/troubleshooting/

@yuvalweber
Copy link
Contributor Author

Hey @tomkerkhove not sure I understand.
Should I delete this file under the 2.13 and just add a new file under the main one?

@zroubalik
Copy link
Member

Thanks for adding this! But this page is automatically updated and you need to create a new file under https://github.com/kedacore/keda-docs/tree/main/content/troubleshooting

@tomkerkhove actually I think that we should change this approach and have a specific content for each version. For example the stuff added in this PR is only valid on versions 2.13+ and also in the current apporach we can't get links to the specific topics in the guide.

@tomkerkhove
Copy link
Member

Thanks for adding this! But this page is automatically updated and you need to create a new file under main/content/troubleshooting

@tomkerkhove actually I think that we should change this approach and have a specific content for each version. For example the stuff added in this PR is only valid on versions 2.13+ and also in the current apporach we can't get links to the specific topics in the guide.

I think we should fix how the troubleshooting widgets are added to be per version, but do think they should all be in separate files as we have it today

@zroubalik
Copy link
Member

Thanks for adding this! But this page is automatically updated and you need to create a new file under main/content/troubleshooting

@tomkerkhove actually I think that we should change this approach and have a specific content for each version. For example the stuff added in this PR is only valid on versions 2.13+ and also in the current apporach we can't get links to the specific topics in the guide.

I think we should fix how the troubleshooting widgets are added to be per version, but do think they should all be in separate files as we have it today

Out of curiosity, why? The rest of the website is done this way :) I don't mind whether the items are in the same file or not, I just want to have it versioned and be able to give a link to specific problem.

To not be completely off topic, @yuvalweber could you please put your stuff the old way, as @tomkerkhove suggested and we will tackle the refactoring in a separate task. Thanks a lot!

@yuvalweber
Copy link
Contributor Author

Added it in different section like you asked @zroubalik.
Let me know if anything else is needed

@yuvalweber
Copy link
Contributor Author

Hey @tomkerkhove it won't let me merge because of your change request which I address to

@zroubalik zroubalik merged commit 3294368 into kedacore:main Oct 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keda-Operator OOM problem after upgrade to Keda v2.11.*
3 participants