Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: OpenTelemetry Collector metrics #1215

Merged
merged 25 commits into from
Sep 28, 2023
Merged

docs: OpenTelemetry Collector metrics #1215

merged 25 commits into from
Sep 28, 2023

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Aug 30, 2023 •
edited by tomkerkhove
Loading

Add a document about how to push metrics to OpenTelemetry Collector

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#4860
Relates to kedacore/keda#3078

@SpiritZhou
Update
75d58e2 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou SpiritZhou requested a review from a team as a code owner August 30, 2023 07:09
@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 6bf2286
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/65143dd3c708b60008752a67
😎 Deploy Preview https://deploy-preview-1215--keda.netlify.app/docs/2.12/operate
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@tomkerkhove tomkerkhove changed the title Add OpenTelemetry Collector Document docs: OpenTelemetry Collector metrics Aug 30, 2023
@tomkerkhove tomkerkhove mentioned this pull request Aug 30, 2023
Merged
5 tasks
tomkerkhove
tomkerkhove reviewed Aug 30, 2023
View reviewed changes
content/docs/2.12/operate/opentelemetry.md Outdated Show resolved Hide resolved
content/docs/2.12/operate/_index.md Outdated Show resolved Hide resolved
content/docs/2.12/operate/opentelemetry.md Show resolved Hide resolved
content/docs/2.12/operate/opentelemetry.md Outdated Show resolved Hide resolved
content/docs/2.12/operate/opentelemetry.md Outdated Show resolved Hide resolved
content/docs/2.12/operate/opentelemetry.md Outdated Show resolved Hide resolved
SpiritZhou and others added 3 commits August 30, 2023 16:12
@SpiritZhou @tomkerkhove
Update content/docs/2.12/operate/opentelemetry.md
637dce3 
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou @tomkerkhove
Update content/docs/2.12/operate/opentelemetry.md
6fafaff 
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou @tomkerkhove
Update content/docs/2.12/operate/_index.md
6e863e0 
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
@tomkerkhove
Copy link
Member

@JorTurFer Do you know why build is failing with this?

target does not exist --- docs/2.12/operate/opentelemetry/index.html --> /docs/2.11/operate/opentelemetry/

I think everything looks fine but maybe you ran in to a similar issue before?

@SpiritZhou @tomkerkhove
Update content/docs/2.12/operate/opentelemetry.md
e2c6ffc 
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: SpiritZhou <[email protected]>
@JorTurFer
Copy link
Member

JorTurFer commented Sep 17, 2023 •
edited
Loading

It's because the current CI checks broken links, and as v2.12 isn't latest, the v2.12 links to latest (v2.11), where that page isn't available.
The exception has to be added in this file: https://github.com/kedacore/keda-docs/blob/main/.htmltest.yml for the moment, and it has to be removed once we release the next version

@SpiritZhou
Update
5faca74 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
e8b2e0a 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
15ed225 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Merge branch 'main' into spiritzhou/opentelemetry
813ee89
@SpiritZhou
Update
ea0e6d9 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
c16f3b7 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
f590ddf 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
87441fc 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
681095a 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
360904e 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
ffdeaab 
Signed-off-by: SpiritZhou <[email protected]>
@SpiritZhou
Update
2a8f515 
Signed-off-by: SpiritZhou <[email protected]>
zroubalik
zroubalik reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpiritZhou looking good, could you please fix the conflict in .htmltest.yml? thanks!

tomkerkhove and others added 2 commits September 27, 2023 14:17
@tomkerkhove tomkerkhove merged commit accd230 into kedacore:main Sep 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pragmaticivan pragmaticivan pragmaticivan left review comments

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer Awaiting requested review from JorTurFer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SpiritZhou @tomkerkhove @JorTurFer @pragmaticivan @zroubalik