feat: Add new feature formula for SO#1198
Merged
JorTurFer merged 6 commits intokedacore:mainfrom Sep 22, 2023
Merged
Conversation
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
While you are waiting, make sure to:
Learn more about:
|
5 tasks
gauron99
force-pushed
the
formula
branch
2 times, most recently
from
7e33ee9 to
2218d83
Compare
tomkerkhove
reviewed
Sep 5, 2023
zroubalik
reviewed
Sep 6, 2023
Member
zroubalik
left a comment
zroubalik
left a comment
There was a problem hiding this comment.
We should mark this as an Experimental feature in the docs.
See this older docs for reference: https://keda.sh/docs/2.9/concepts/scaling-deployments/#caching-metrics-experimental
Contributor
Author
|
@zroubalik @tomkerkhove PTAL i moved the examples into separate section underneath the general section and clarified the fallback comment. |
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
zroubalik
approved these changes
Sep 22, 2023
zroubalik
reviewed
Sep 22, 2023
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
zroubalik
approved these changes
Sep 22, 2023
JorTurFer
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
provide documentation for new feature, which is defined in SO.
here -> new feature implementation
Checklist