Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated metricName description with deprecation notice #1072

Closed
wants to merge 3 commits into from
Closed

Updated metricName description with deprecation notice #1072

wants to merge 3 commits into from

Conversation

OsamaNabih
Copy link

@OsamaNabih OsamaNabih commented Feb 15, 2023

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #
PR: kedacore/keda#4230
Issue: kedacore/keda#4240

@OsamaNabih OsamaNabih requested a review from a team as a code owner February 15, 2023 20:55
@netlify
Copy link

netlify bot commented Feb 15, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 46dc886
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/63ee927fa5cc590008762fcf
😎 Deploy Preview https://deploy-preview-1072--keda.netlify.app/docs/2.10/scalers/prometheus
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

content/docs/2.10/scalers/prometheus.md Outdated Show resolved Hide resolved
@tomkerkhove
Copy link
Member

@OsamaNabih I don't see a linked feature PR - Can you add it please? We should link to feature PR + issue

OsamaNabih and others added 2 commits February 16, 2023 22:30
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Osama Nabih <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Osama Nabih <[email protected]>
@OsamaNabih
Copy link
Author

@OsamaNabih I don't see a linked feature PR - Can you add it please? We should link to feature PR + issue

I've added links to the PR and issue.

@OsamaNabih OsamaNabih closed this by deleting the head repository Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants