interceptor: make request logging optional#1375
Merged
wozniakjan merged 1 commit intokedacore:mainfrom Nov 26, 2025
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
ec1584b to
82012da
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes interceptor request logging optional by introducing a new environment variable KEDA_HTTP_LOG_REQUESTS that defaults to false, addressing performance and log verbosity concerns in production environments.
Key changes:
- Added
LogRequestsconfiguration field to enable/disable request logging viaKEDA_HTTP_LOG_REQUESTSenvironment variable - Modified logging middleware to accept an optional logger pointer and skip logging when nil
- Added documentation for the new configuration option
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
interceptor/config/serving.go |
Added LogRequests boolean field with environment variable binding |
interceptor/middleware/logging.go |
Changed logger to pointer type and added nil check to make logging optional |
interceptor/main.go |
Conditionally initializes logger pointer based on LogRequests config |
docs/operate.md |
Added documentation section for request logging configuration |
CHANGELOG.md |
Updated with improvement entry for optional request logging |
.github/workflows/linkinator.yaml |
Fixed lychee link checker argument from --base-url to --root-dir |
.github/PULL_REQUEST_TEMPLATE.md |
Corrected relative path to docs directory |
.github/ISSUE_TEMPLATE/3_release_tracker.md |
Fixed malformed markdown link syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zroubalik
approved these changes
Nov 20, 2025
JorTurFer
reviewed
Nov 20, 2025
JorTurFer
approved these changes
Nov 20, 2025
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
82012da to
bb8c581
Compare
JorTurFer
approved these changes
Nov 20, 2025
JorTurFer
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two minor changes
--base-urlno longer accepts relative paths and should be replaced by--root-dir- see also: feat(base-url)!: disallow relative local base to avoid confusion lycheeverse/lychee#1857 and https://github.com/lycheeverse/lychee/releases/tag/lychee-v0.21.0Checklist
docs/directory