fix: check endpoint readiness before forwarding #1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Wozniak <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression where the interceptor doesn't wait for endpoints to be ready for traffic before forwarding requests. The fix adds a readiness check to ensure only ready endpoints are counted when determining workload availability.
- Added endpoint readiness check to prevent traffic forwarding to non-ready endpoints
- Includes proper null handling for the Ready condition field per Kubernetes API specification
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zroubalik
approved these changes
Oct 3, 2025
Copilot AI
pushed a commit
that referenced
this pull request
Oct 6, 2025
Signed-off-by: Jan Wozniak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during #1298, we introduced a regression where the interceptor doesn't wait for endpoint to be ready for traffic.
Checklist
Fixes: #1344