Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide introduction and background on KEDA in CNCF Graduation proposal #2

Merged

Conversation

tomkerkhove
Copy link
Member

Provide introduction and background on KEDA in CNCF Graduation proposal

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/governance#63

Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Signed-off-by: Tom Kerkhove <[email protected]>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have done an awesome job @tomkerkhove.
Congrats!!!
I only left one comment inline and another suggestion here (because I'm not sure about the correct place): Maybe we should attach a picture about the community increase (insights page in the repo). Ignoring summer, the contributions have grown during the last year
image

proposals/graduation/keda.md Show resolved Hide resolved
Copy link

@sfc-gh-jhollan sfc-gh-jhollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job. The tone of the proposal is strong

Copy link
Member

@jeffhollan jeffhollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from my personal GitHub :)

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job, congrats!! 🙇

@JorTurFer JorTurFer removed their assignment Sep 14, 2022
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

proposals/graduation/keda.md Show resolved Hide resolved
Signed-off-by: Tom Kerkhove <[email protected]>
@tomkerkhove
Copy link
Member Author

Let's do this 🚀

@tomkerkhove tomkerkhove merged commit 7660f6b into keda-graduation-proposal Sep 14, 2022
@tomkerkhove tomkerkhove deleted the keda-graduation-proposal-introduction branch September 14, 2022 11:04
tomkerkhove pushed a commit that referenced this pull request Jan 9, 2023
…-operations

Update environmentalsustainability.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants