operator cert auto-management: make APIService cert injections optional#832
Conversation
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
d659206 to
d2916df
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a Helm value to make the KEDA operator’s APIService CA/cert injection behavior configurable when using self-generated certificates, and wires that value into the operator Deployment plus documentation.
Changes:
- Add
certificates.operator.apiServicePatching.enabled(defaulttrue) tovalues.yaml. - Pass
--enable-apiservice-patching=...to the operator container args (whencertificates.autoGeneratedis enabled). - Document the new value in the chart README.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
keda/values.yaml |
Introduces the new apiServicePatching.enabled configuration under certificates.operator. |
keda/templates/manager/deployment.yaml |
Adds a new operator CLI flag derived from the new Helm value. |
keda/README.md |
Documents the new Helm value in the generated values table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
46d52b1 to
0025708
Compare
…vicePatching Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
0025708 to
6b0394d
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds an optional Helm value to control whether the KEDA operator patches the Metrics API APIService CA bundle when using auto-generated certificates (non–cert-manager), exposing the operator’s new --enable-apiservice-patching flag through the chart.
Changes:
- Document a new optional value
certificates.operator.apiServicePatching.enabled(default unset) invalues.yamlandREADME.md. - Conditionally pass
--enable-apiservice-patchingto the operator Deployment when the value is configured and auto-generated certs are in use.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
keda/values.yaml |
Adds commented configuration/docs for optional APIService patching control under certificates.operator. |
keda/templates/manager/deployment.yaml |
Conditionally appends the new operator CLI flag based on cert settings and the new value. |
keda/README.md |
Documents the new value and its implications (especially for metricsServer.enabled=true). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Checklist