-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errors in service account template. #264
Conversation
Signed-off-by: Vighnesh Shenoy <[email protected]>
@tomkerkhove Kinda new to helm charts, so I didn't realize I could install from local directories. So I didn't test my changes until I pushed them to the PR. After trying to install from local, I realized I made some mistakes, please merge otherwise the helm changes will throw errors. Sorry for the inconvenience. |
No problem at all! Normally the CI should have caught that but we don't test all configuration scenarios, unfortunately. |
Let's not merge this PR just yet. |
Signed-off-by: Vighnesh Shenoy <[email protected]>
The convention is |
Oh. I just had a quick glance and I thought |
Signed-off-by: Vighnesh Shenoy <[email protected]>
Signed-off-by: Vighnesh Shenoy [email protected]
Provide a description of what has been changed
Checklist
Relates to kedacore/keda#2487
Relates to #263