Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in service account template. #264

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Apr 26, 2022

Signed-off-by: Vighnesh Shenoy [email protected]

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
  • README is updated with new configuration values (if applicable)

Relates to kedacore/keda#2487
Relates to #263

@v-shenoy v-shenoy requested a review from a team as a code owner April 26, 2022 10:25
@v-shenoy
Copy link
Contributor Author

v-shenoy commented Apr 26, 2022

@tomkerkhove Kinda new to helm charts, so I didn't realize I could install from local directories. So I didn't test my changes until I pushed them to the PR. After trying to install from local, I realized I made some mistakes, please merge otherwise the helm changes will throw errors.

Sorry for the inconvenience.

keda/templates/01-serviceaccount.yaml Outdated Show resolved Hide resolved
@tomkerkhove
Copy link
Member

No problem at all! Normally the CI should have caught that but we don't test all configuration scenarios, unfortunately.

@tomkerkhove
Copy link
Member

Let's not merge this PR just yet.

Signed-off-by: Vighnesh Shenoy <[email protected]>
@tomkerkhove
Copy link
Member

The convention is {{ .Values.podIdentity.azureWorkload.tokenExpiration | quote }} over {{ quote .Values.podIdentity.azureWorkload.tokenExpiration }} but that's OK.

@v-shenoy
Copy link
Contributor Author

The convention is {{ .Values.podIdentity.azureWorkload.tokenExpiration | quote }} over {{ quote .Values.podIdentity.azureWorkload.tokenExpiration }} but that's OK.

Oh. I just had a quick glance and I thought | quote would mostly be used if I had multiple functions being chained. My bad.

Signed-off-by: Vighnesh Shenoy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants