Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keaven's plotgsPower() updates #127

Closed

Conversation

jdblischak
Copy link
Contributor

This is an alternative to #126. It is mostly identical. The minor differences are due to:

  1. In Plotgspower update #126, Keaven made a few extra edits while fixing the merge conflicts (eg dgt = 4). This PR does not contain those changes
  2. In this PR, I was able to keep a final commit from Keaven that he made after merging master. We had removed this commit while preparing Plotgspower update #126. However, I suspect that most of those edits were reverting to changes already in the master branch, because the differences I see locally with git diff HEAD~1 vignettes/SurvivalOverview.Rmd don't appear in this PR

In the end, both this PR and #126 edit the vignette SurvivalOverview.Rmd. We need to pick one and then close the other.

@jdblischak
Copy link
Contributor Author

Superseded by #126

@jdblischak jdblischak closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants