Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading image into TVPosterView #602

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

lukaskukacka
Copy link

TVPosterView now supports loading image using Nuke out-of-the-box (TVPosterView now conforms to Nuke_ImageDisplaying).

TVPosterView is a crucial UI component on tvOS.
While it is easy to add this conformance in your project, imho it is nice to have it out of the box in the library.


In my specific case, having it directly in the library is actually the only way to make my whole project to compile.

Custom conformance in my project worked fine with Nuke v. 10, but since update to v. 11 (which moves these extensions to NukeExtensions), using custom extension will no longer compile.

I guess it is caused by how Swift access control works + specific setup of my project (private frameworks with multi-level hierarchy + Nuke hidden privately in one of private frameworks under custom wrapper interface).


Thanks a lot for considering my change.
And big thanks for your time and effort on this amazing library! 🙂

`TVPosterView` now supports loading image using Nuke out-of-the-box
(`TVPosterView` now conforms to `Nuke_ImageDisplaying`)
@kean
Copy link
Owner

kean commented Sep 17, 2022

Thanks for the contribution, @lukaskukacka. I appreciate that you even added a unit test.

@kean kean merged commit 9701648 into kean:master Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants