Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataLoader delegate for easy Pulse integration #583

Merged
merged 6 commits into from
Aug 7, 2022

Conversation

kean
Copy link
Owner

@kean kean commented Aug 7, 2022

Pulse 2.0 is optimized for working with images and now is a good time to provide a convenient way to integrate it with Nuke.

  • Add delegate: URLSessionDelegate? property to DataLoader for observing network events
  • Deprecated the existing observer: DataLoaderObserving

Pulse can now be integrated with a single line of code:

(ImagePipeline.shared.configuration.dataLoader as? DataLoader)?.delegate = URLSessionProxyDelegate()

Screenshot 2022-08-07 at 2 23 30 PM

The demo project was also updated to feature Pulse.

Screenshot 2022-08-07 at 2 23 30 PM

@kean kean merged commit 16ae380 into master Aug 7, 2022
@kean kean deleted the data-loader-delegate branch August 7, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant