Image Decoding Improvements #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kean
force-pushed
the
image-decoding-guide
branch
3 times, most recently
from
c69abcf to
62c8d09
Compare
kean
force-pushed
the
image-decoding-guide
branch
from
62c8d09 to
0e61b9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageDecoders.Defaultto_ImageDecodingprotocolImageDecoders.Defaultnow automatically attached the original image data to the image container for .gifImageResponse.scanNumber, the scan number is now passed inImageContainer.userInfo[ImageDecoders.Default.scanNumberKey](this is a format-specific feature and that's why I made it non-type safe and somewhat hidden). Previusly it was also only working for the defaultImageDecoders.Default. Now any decoder can pass scan number, or any other information usingImageContainer.userInfoisAnimatedImageDataEnabledcachedResponse(for url: URL)thing