Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoundedCorners and Circle image processor Border width #327

Merged
merged 2 commits into from
Nov 13, 2019
Merged

RoundedCorners and Circle image processor Border width #327

merged 2 commits into from
Nov 13, 2019

Conversation

ejensen
Copy link
Contributor

@ejensen ejensen commented Nov 12, 2019

The RoundedCorners image processor has an existing Border parameter. However It was not respecting the border.width when drawing the stroke. The stoke was always drawn with a width of 1.
This PR corrects the width of the stroke border in the RoundedCorners processor.

This PR also adds an optional border parameter to the Circle processor. The new parameter defaults to nil in order to prevent a breaking API change.

@kean
Copy link
Owner

kean commented Nov 13, 2019

Thanks, @ejensen! This looks good. I don't remember why Border was implemented this way initially, it's great that it now works as expected.

I'm going to merge this and I will also add a typealias ImageProcessor. RoundedCorners.Border = ImageProcessor.Border to make sure there are no breaking API changes. Thanks again. If you see any other issues in processors, please let me know. They are a new addition in Nuke 8, not as polished yet.

@kean kean merged commit 8f80456 into kean:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants